feat(@angular/cli): add platform: server - #5547
Conversation
7fa7e51 to
492d6d5
Compare
492d6d5 to
80a2b85
Compare
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
Can you add a test that confirms this functionality?
80a2b85 to
fe07ade
Compare
|
From what I understand from the commits, polyfills have been moved from common config to browser only config. But server rendering needs the polyfills too. And for zone.js, it even needs a different import : |
hansl
left a comment
hansl
left a comment
There was a problem hiding this comment.
1 nit which will help with documentation, and it's all good.
| "description": "The output directory for build results." | ||
| }, | ||
| "platform": { | ||
| "type": "string", |
There was a problem hiding this comment.
Should this be an enum instead of string?
There was a problem hiding this comment.
There is no "enum" type. More like:
"platform": {
"type": "string",
"enum": ["browser", "server"],
"description": "The destination platform of app."
}
|
We should disable |
|
Looking forward this feature) |
|
@FrozenPandaz Thanks so much for taking this on! Any idea on when you will get a chance to have a look at this again? I'm eagerly awaiting this feature ;) |
|
This is superseded by #6913 ? |
|
Closed by #6913. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
9 participants
This adds the platform field to the cli config.
"browser"is by default and"server"is also allowed.passing server will generate a bundle meant for the server via ng build